[Webkit-unassigned] [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests

Thu Apr 26 07:19:21 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=84446

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138986|review?                     |review+
               Flag|                            |

--- Comment #17 from Philippe Normand <pnormand at igalia.com>  2012-04-26 07:19:21 PST ---
(From update of attachment 138986)
View in context: https://bugs.webkit.org/attachment.cgi?id=138986&action=review

Alright, looks good! Please don't forget to file new bugs for the skipped tests.

> Tools/ChangeLog:18
> +        * TestWebKitAPI/JavaScriptTest.cpp: Use
> +        JavaScriptCore/JSContextRef.h instead of
> +        JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
> +        unconditionally.

Maybe I'm wrong but I think this issue should still be fixed. JavaScriptCore.h shouldn't unconditionally include CF headers if it's meant to be used by non-mac ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.