[Webkit-unassigned] [Bug 82286] [EFL][DRT] Implement LayoutTestController::execCommand

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 17:48:23 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82286





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-25 17:48:20 PST ---
(From update of attachment 138792)
View in context: https://bugs.webkit.org/attachment.cgi?id=138792&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:401
> +void DumpRenderTreeSupportEfl::executeCoreCommandByName(const Evas_Object* ewkView, const gchar* name, const gchar* value)

Why do you use gchar instead of char? EFL port should use glib library as less as possible.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:420
> +bool DumpRenderTreeSupportEfl::isCommandEnabled(const Evas_Object* ewkView, const gchar* name)

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list