[Webkit-unassigned] [Bug 84830] [EFL] Enable VIDEO_TRACK feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84830





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-25 17:02:12 PST ---
(From update of attachment 138784)
View in context: https://bugs.webkit.org/attachment.cgi?id=138784&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:724
> +    priv->settings.shouldDisplaySubtitles = priv->pageSettings->shouldDisplaySubtitles();

I think it is better to add this settings by alphabetic sorting. So, is it better to move below 729 line.

> Source/WebKit/efl/ewk/ewk_view.cpp:4084
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

Use standard boolean type instead of EINA_FALSE.

> Source/WebKit/efl/ewk/ewk_view.cpp:4085
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4108
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4109
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4132
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.cpp:4133
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit/efl/ewk/ewk_view.h:2460
> +EAPI void ewk_view_setting_should_display_subtitles_set(const Evas_Object *o, Eina_Bool enable);

We don't use const keyword in _set APIs.

> Source/WebKit/efl/ewk/ewk_view.h:2481
> +EAPI void ewk_view_setting_should_display_captions_set(const Evas_Object *o, Eina_Bool enable);

ditto.

> Source/WebKit/efl/ewk/ewk_view.h:2502
> +EAPI void ewk_view_setting_should_display_text_descriptions_set(const Evas_Object *o, Eina_Bool enable);

ditto.

> Tools/ChangeLog:10
> +        * Scripts/build-webkit:

Missing description.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.