[Webkit-unassigned] [Bug 84718] [EFL][DRT] LayoutTestController addUserScript implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84718





--- Comment #9 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-04-25 13:15:20 PST ---
(In reply to comment #7)
> (From update of attachment 138764 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138764&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:662
> > +    DumpRenderTreeSupportEfl::addUserScript(browser->mainView(), WTF::String(source->characters(), source->length()), runAtStart, allFrames);
> 
> We generally create the String object by passing the StringImpl* returned by UString directly:
>   String(source->ustring().impl())

Fixed.
Actually I see that WTF::String(source->characters(), source->length()) construction is used in LayoutTestControllerEFL:queueLoad(), do you think it also should be corrected same way?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.