[Webkit-unassigned] [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84446





--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-25 08:20:32 PST ---
(In reply to comment #14)
> (From update of attachment 138743 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138743&action=review
> 
> > Tools/TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:48
> > +    g_timeout_add(500, checkTestFinished, done);
> 
> This means that every test will be at least 500 milliseconds long, which means that 20 tests will take at least 10 seconds to run. Don't you think it makes more sense to make this g_idle_add or something similar? Windows and Mac do this test on literally every cycle of the main loop.

Yes, sure, I'll use a g_idle instead.

> > Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:121
> > +    GtkWidget* viewWidget = GTK_WIDGET(m_view);
> > +    if (!gtk_widget_get_realized(viewWidget))
> > +        gtk_widget_show(m_window);
> > +    doMouseButtonEvent(viewWidget, GDK_BUTTON_PRESS, x, y, 3);
> > +    doMouseButtonEvent(viewWidget, GDK_BUTTON_RELEASE, x, y, 3);
> 
> Depending on the design of the context menu API, we may need to add some extra logic here. If we add a default action which opens the context menu on right clicks, we'll need to block that here in the future. It might be worth putting a small comment.

Context menu API doesn't affect the C API at all. C API users are supposed to add their own implementation of the ContextMenuClient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.