[Webkit-unassigned] [Bug 84864] New: [Qt] Printing Page-Layouting broken (height unknown)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84864

           Summary: [Qt] Printing Page-Layouting broken (height unknown)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Printing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: milian.wolff at kdab.com


Printing with the Qt port is currently broken, because the page height is not passed to the print context. This results in various issues, most prominently all those page-break-* CSS3 attributes are not handled.

The reason that this was not catched by the existing unit tests, is that no ref/pixel test exists for this. Instead, the current tests use LTC::pageNumberForElementById which eventually calls PrintContext::pageNumberForElement, bypassing QWebFrame::print alltogether.

The fix is trivial, one just needs to replace

    printContext.begin(pageRect.width());

with

    printContext.begin(pageRect.width(), pageRect.height());

in QWebFrame::print. I'll supply a patch for that. But I see no way to write a unit test for that (as that code creates PDFs). Anyhow, lets hope you will merge it anyways.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.