[Webkit-unassigned] [Bug 84542] [chromium][workers] setTargetType(ResourceRequest::TargetIsWorker) is repeatedly called in chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84542





--- Comment #15 from David Levin <levin at chromium.org>  2012-04-25 07:45:54 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 138740 [details] [details])
> > I wonder why http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55 isn't changed to be "|| PLATFORM(BLACKBERRY)" and then just get rid of this.
> > 
> > But this is fine as is.  Thanks!
> 
> You should look this linked address. http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/Worker.cpp&type=cs&l=73

I don't understand what you are saying. The line that you referred to is the code you are changing.

Here's what I was saying. On blackberry, this field is uninitialized because on this line
http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/WorkerScriptLoader.cpp&type=cs&l=55

it is only initialized for Chromium.

If we changed that line to also initialize the field for blackberry, then this line
http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/workers/Worker.cpp&type=cs&l=73

would be necessary on blackberry either and it could be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.