[Webkit-unassigned] [Bug 61065] [GTK][WebKit2] Initial windowed plugins implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61065





--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-25 05:12:21 PST ---
(In reply to comment #15)
> (From update of attachment 117182 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117182&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:229
> > +bool NetscapePlugin::platformPostInitialize()
> > +{
> > +#if PLATFORM(GTK)
> > +    if (moduleMixesGtkSymbols(m_pluginModule->module()))
> > +        return false;
> > +#endif
> > +
> > +    uint64_t windowID = 0;
> 
> I think we should still short-circuit the windowed case for Qt since we don't support it.

The patch shouldn't break Qt, if windowID is 0 (which will be the case of Qt until it's implemented), it returns early.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.