[Webkit-unassigned] [Bug 84718] [EFL][DRT] LayoutTestController addUserScript implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84718





--- Comment #5 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-04-25 02:26:20 PST ---
(In reply to comment #2)
> (From update of attachment 138670 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138670&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:662
> > +    DumpRenderTreeSupportEfl::addUserScript(browser->mainView(), source->ustring().utf8().data(), runAtStart, allFrames);
> 
> Please create the String object here instead of passing a char* around and thus avoid an unneeded conversion.

Thanks for review! Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.