[Webkit-unassigned] [Bug 84820] [BlackBerry] [DRT] Some HTTP tests can't access relative css and/or javascript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84820


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138757|review?                     |review+
               Flag|                            |




--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2012-04-25 01:29:53 PST ---
(From update of attachment 138757)
View in context: https://bugs.webkit.org/attachment.cgi?id=138757&action=review

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:345
> +    return test.lower().substring(0, strlen(httpTestSyntax)) == httpTestSyntax
> +            && test.lower().substring(strlen(httpTestSyntax), strlen(localTestSyntax)) != localTestSyntax;

You could cache test.lower(), and the results of the strlen() calls in local variables. Though as this is a DRT patch, I'll r+ it nevertheless, feel free to make the changes, and reupload a patch or set cq+ on this one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.