[Webkit-unassigned] [Bug 84670] [EFL][DRT] "resource, request, willsend" signal needs to provide more information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84670





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-25 00:38:55 PST ---
(From update of attachment 138497)
View in context: https://bugs.webkit.org/attachment.cgi?id=138497&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:200
> +        redirectResponse = &responseBuffer;

I wonder why you don't use redirectResponse directly in order to send messages to application via signal.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:201
> +    }

Add blank line to here.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:203
> +

It is better to remove blank line.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:205
> +

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.