[Webkit-unassigned] [Bug 84718] [EFL][DRT] LayoutTestController addUserScript implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 15:58:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84718





--- Comment #2 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-24 15:58:30 PST ---
(From update of attachment 138670)
View in context: https://bugs.webkit.org/attachment.cgi?id=138670&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:662
> +    DumpRenderTreeSupportEfl::addUserScript(browser->mainView(), source->ustring().utf8().data(), runAtStart, allFrames);

Please create the String object here instead of passing a char* around and thus avoid an unneeded conversion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list