[Webkit-unassigned] [Bug 83298] getMatchedCSSRules() should return null when the second argument is an unrecognized pseudo-element name

Tue Apr 24 11:38:03 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=83298

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138598|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2012-04-24 11:38:01 PST ---
(From update of attachment 138598)
View in context: https://bugs.webkit.org/attachment.cgi?id=138598&action=review

The C++ code looks good. I'm not sure about the idl changes though. Someone more familiar with idl should review that.

With the test, just a few nits. We try to keep as much boilerplate out of the tests as possible. Makes it easier to see what's going on.

Can you provide a link in the ChangeLog description to the appropriate CSS spec or www-style discussion for this behavior?

r- to resolve the above couple issues. Then someone with more idl experience can r+.

> LayoutTests/fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html:4
> +<html>
> +<head>
> +<meta charset="utf-8">

You don't need these elements.

> LayoutTests/fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html:5
> +<style type="text/css" media="screen">

you don't need the type or media attributes, do you?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.