[Webkit-unassigned] [Bug 84738] [BlackBerry] setUserViewportArguments not always respected.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84738





--- Comment #3 from Antonio Gomes <tonikitoo at webkit.org>  2012-04-24 10:37:26 PST ---
(From update of attachment 138592)
View in context: https://bugs.webkit.org/attachment.cgi?id=138592&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:3158
> -        currentViewportArguments.targetDensityDpi = deviceDPI;
> +        m_viewportArguments.targetDensityDpi = deviceDPI;
>      }

we set 'deviceDPI' here...

> Source/WebKit/blackberry/Api/WebPage.cpp:3160
> -    ViewportAttributes result = computeViewportAttributes(currentViewportArguments, desktopWidth, deviceWidth, deviceHeight, deviceDPI, m_defaultLayoutSize);
> +    ViewportAttributes result = computeViewportAttributes(m_viewportArguments, desktopWidth, deviceWidth, deviceHeight, deviceDPI, m_defaultLayoutSize);

... and pass it as a parameter here. Is it really needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.