[Webkit-unassigned] [Bug 84446] [GTK] Build and run TestWebKitAPI WebKit2 unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84446


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2012-04-24 09:06:48 PST ---
(In reply to comment #6)

> > > Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:76
> > > +    gtk_main_do_event(event.get());
> > > +    event->key.type = GDK_KEY_RELEASE;
> > > +    gtk_main_do_event(event.get());
> > 
> > Is it okay for this to happen asynchronously or do the tests expect that it be finished by the time the method returns?
> 
> I'm not sure, why?

Assuming that gtk_main_do_event works asynchronously (I believe it does, but perhaps I'm misremembering), there is a chance that the event may still be on the event queue. If the code that calls this method expects WebKit to have already processed the event, the test will likely fail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.