[Webkit-unassigned] [Bug 61065] [GTK][WebKit2] Initial windowed plugins implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61065





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-24 08:38:42 PST ---
(In reply to comment #13)
> (From update of attachment 117182 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117182&action=review
> 
> >>> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:231
> >>> +    IntRect geometry(priv->children.get(child));
> >> 
> >> A different assignment style is used in webkitWebViewBaseChildMoveResize. Can the code be more coherent in that regard, if possible?
> > 
> > Sure
> 
> Typically, assignment in WebKit uses the C syntax. I'm not sure if the entire code base follows this rule. I've definitely seen other reviewers express this desire before though, so it's best to stick with what's typical in the project, I think. I believe this could be considered one of the unwritten rules.

Ok, I'll use the C-style then, thanks for the clarification.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.