[Webkit-unassigned] [Bug 82598] [GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82598





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-24 08:15:05 PST ---
(In reply to comment #6)
> (From update of attachment 135292 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135292&action=review
> 
> LGTM
> 
> > Source/WebCore/platform/network/soup/CookieStorageSoup.cpp:36
> > +void setCookieStoragePrivateBrowsingEnabled(bool enabled)
> > +{
> > +    notImplemented();
> 
> Would it make sense to start/stop observing cookies there? depending on the enabled value.
> I can't find this function used in WebKit2 btw, is it part of some DerivedSources or was it removed from the other ports?

This function is declared in CookieStorage.h so we need to provide an implementation even if it's empty. When private browsing is enabled, the cookie storage used for private browsing will be observed for changes, so I don't think we need to do anything here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.