[Webkit-unassigned] [Bug 84559] [Blackberry] remove m_isRequestedByPlugin in ResourceRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84559





--- Comment #4 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-04-24 03:57:35 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > +gen.
> > 
> > As I remember, it was added to avoid popping up a window when start scrolling a page off of a Flash Ad (for example, cnn.com full edition, right side of the webpage). However it did not completely cover all cases, and popups are still opened in many real world web sites ever with this hack.
> > 
> > As I said, it does fixes some cases, but not all..
> 
> I was searching our code, only dispatchDecidePolicyForNewWindowAction is using "isRequestedByPlugin", do we have other cases?
> I removed the code in dispatchDecidePolicyForNewWindowAction, because isRequestedByPlugin seems to be always false without my that fixing(https://bugs.webkit.org/show_bug.cgi?id=83447), and the code run well long time without hitting those code I removed.

Gen & Antonio,
I guess the first policyChecker is useless, because there is not an early return. So the second policyChecker is working actually. let me summarize the options I have:
1. remove them, just like my patch 
2. just remove "request.isRequestedByPlugin()"
3. #2 + early return;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.