[Webkit-unassigned] [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or ,

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84582





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-23 23:45:27 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > 
> > > Is it possible to implement this correctly without merging the regexps? Frankly, both of these regexps were already verging on unmaintainable.
> > 
> > This might be tricky. It's unclear what to do with a string like this "Reviewed by Pawel Hadjan, Jr., Martin Robinson, and Carlos Garcia Campos." 
> 
> Isn't that case is hard to deal with regardless of whether the regexps are merged?

Yes, this patch doesn't try to fix the reviewer text case, because it's impossible to know whether a , is part of a name or a separator. Fortunately multiple reviewers is not that common, so having a commit with multiple reviewers and one of them having a , in the name is very unlikely. Commits with multiple author is common though. 

I tried to fix the test cases I added to the unit tests using the existing functions, just playing with the regexp, but didn't manage to fix it until I merged both regexps, because we need the pattern name <email> in the regexp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.