[Webkit-unassigned] [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84435





--- Comment #4 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-23 19:33:23 PST ---
(From update of attachment 138291)
View in context: https://bugs.webkit.org/attachment.cgi?id=138291&action=review

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:600
>  void FrameLoaderClientEfl::dispatchDidChangeIcons(WebCore::IconType)

Shouldn't the parameter for this method be used now so the signal can be more useful? Right now it looks like only DRT has a good use for this feature.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:604
> +    // report received favicon only for main frame.
> +    if (ewk_view_frame_main_get(m_view) != m_frame)
> +        return;

What's the reason for emitting this signal only for the main frame?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.