[Webkit-unassigned] [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or ,

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84582





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2012-04-23 15:01:05 PST ---
(In reply to comment #9)

> Is it possible to implement this correctly without merging the regexps? Frankly, both of these regexps were already verging on unmaintainable.

This might be tricky. It's unclear what to do with a string like this "Reviewed by Pawel Hadjan, Jr., Martin Robinson, and Carlos Garcia Campos." You could make it work for the attribution line by only splitting names if the comma is prefixed by the end of an email address ala "Pawel Hadjan, Jr. <foo at foo.com>, Martin Robinson <mrobinson at webkit.org>, and Carlos Garcia Campos <cgarcia at igalia.com>." That means we'd need two copies of the regex though, I think. Perhaps it's easiest to just strip ", Jr." and the like from the string before processing. That would make things a lot simpler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.