[Webkit-unassigned] [Bug 71143] [Meta] Master bug for sub-pixel layout branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71143





--- Comment #80 from Eric Seidel <eric at webkit.org>  2012-04-23 11:12:51 PST ---
(From update of attachment 138382)
View in context: https://bugs.webkit.org/attachment.cgi?id=138382&action=review

Honestly this seems fine.   You reach a point where it will be more efficient to move testing onto the build bots instead of the EWS bots. :)

> Source/WebCore/rendering/LayoutTypes.h:84
> +    return LayoutPoint(p.x(), p.y());

Why is this one LayoutPoint and the one above it FractionalLayoutPoint?

> Source/WebCore/rendering/RenderTreeAsText.cpp:110
> +    // FIXME: These should be printed as floats. Keeping them ints for consistency with pervious test expectations.
> +    return ts << "(" << p.x().toInt() << "," << p.y().toInt() << ")";

Ah, you have joined a long tradition here. :)

> Source/WebCore/rendering/RenderTreeAsText.cpp:279
> +    // FIXME: Convert layout test results to report sub-pixel values, in the meantime using enclosingIntRect
> +    // for consistency with old results. This doesn't apply to tables, which are still laid out on integer bounds.

WE need to come up with a list of htese and do them all at once some day. :)

> Source/WebCore/rendering/PaintInfo.h:101
> -    static IntRect infiniteRect() { return IntRect(INT_MIN / 2, INT_MIN / 2, INT_MAX, INT_MAX); }
> +    static IntRect infiniteRect() { return IntRect(LayoutRect::infiniteRect()); }

This seems odd.  I guess it makes sense for this to be based on LayoutRect?  And if so why not call toInt()?  (Or maybe that doesn't exist).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.