[Webkit-unassigned] [Bug 64883] Zoom only scales frames' content, not the frames themselves.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64883





--- Comment #11 from Emil A Eklund <eae at chromium.org>  2012-04-23 10:25:01 PST ---
(From update of attachment 111398)
View in context: https://bugs.webkit.org/attachment.cgi?id=111398&action=review

>> Source/WebCore/rendering/RenderFrameSet.cpp:218
>> +            gridLayout[i] = max(static_cast<int>(grid[i].value() * style()->effectiveZoom()), 0);
> 
> Are you sure we just want to cast it to int? Don't we need to use on of those fancy snapping functions listed on http://trac.webkit.org/wiki/LayoutUnit?

I'm not entirely sure what you are trying to do here but it seems like you'd want to use snapSizeToPixel or somehow account for the rounding error or the last column/row will end up with all the extra space from the accumulated flooring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.