[Webkit-unassigned] [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or ,

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 23 08:53:41 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84582





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-23 08:53:40 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> 
> > That would fix the case of +, but list of authors separated by , don't usually have spaces around.
> > 
> > Foo Bar <foo at bar.com>, Baz <bazmail at webkit.org>
> 
> It would probably be enough only to make this a requirement for characters that can also exist in names and email addresses. Specifically, the words "and" and "+".

that wouldn't fix the real test case I added to the unit tests where there's a , in the author name. What's wrong with the proposed regexp? It fixes all test cases.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list