[Webkit-unassigned] [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or ,

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84582





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-23 08:19:08 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> 
> > As I said in the description _parse_author_name_and_email uses _split_contributor_names which splits the text using a set of separators when they are found *at any position of the text*. That means that a , or + in the inside an author name or email would split the name or email. Merging both, and using findall, it looks for name <email> patterns separated by the set of separators.
> 
> Sorry, I missed that.
> 
> Would it be possible to modify the regular expression to simply enforce spaces around '+'?  That will allow us to keep the nice abstraction between splitting the name and email addresses and splitting things with "and", "&&", etc.

That would fix the case of +, but list of authors separated by , don't usually have spaces around.

Foo Bar <foo at bar.com>, Baz <bazmail at webkit.org>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.