[Webkit-unassigned] [Bug 84582] webkitpy: changelog crashes when parsing authors containing + or ,

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84582





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-04-23 08:10:38 PST ---
(In reply to comment #2)
> (From update of attachment 138318 [details])
> I feel like the ChangeLog might be missing the "why." From your patch it looks like (unless I have misread) that you combined the regular expression to split things containing "and" or "&" into multiple parts with the regular expression that parses the name and email combination. I don't understand exactly why that fixes the problem.

As I said in the description _parse_author_name_and_email uses _split_contributor_names which splits the text using a set of separators when they are found *at any position of the text*. That means that a , or + in the inside an author name or email would split the name or email. Merging both, and using findall, it looks for name <email> patterns separated by the set of separators.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.