[Webkit-unassigned] [Bug 84582] New: webkitpy: changelog crashes when parsing authors containing + or ,

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84582

           Summary: webkitpy: changelog crashes when parsing authors
                    containing + or ,
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cgarcia at igalia.com


E......
======================================================================
ERROR: test_parse_authors (webkitpy.common.checkout.changelog_unittest.ChangeLogTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "webkitpy/common/checkout/changelog_unittest.py", line 433, in test_parse_authors
    [('James Simonsen', 'simonjam+webkit at google.com')])
  File "webkitpy/common/checkout/changelog_unittest.py", line 417, in _assert_parse_authors
    parsed_authors = [(author['name'], author['email']) for author in self._entry_with_author(author_text).authors()]
  File "webkitpy/common/checkout/changelog_unittest.py", line 376, in _entry_with_author
    '''.replace("AUTHOR_TEXT", author_text))
  File "webkitpy/common/checkout/changelog.py", line 104, in __init__
    self._parse_entry()
  File "webkitpy/common/checkout/changelog.py", line 165, in _parse_entry
    self._authors = ChangeLogEntry._parse_author_text(self._author_text)
  File "webkitpy/common/checkout/changelog.py", line 156, in _parse_author_text
    return [ChangeLogEntry._parse_author_name_and_email(author) for author in authors]
  File "webkitpy/common/checkout/changelog.py", line 148, in _parse_author_name_and_email
    return {'name': match.group("name"), 'email': match.group("email")}
AttributeError: 'NoneType' object has no attribute 'group'

----------------------------------------------------------------------
Ran 16 tests in 0.566s

FAILED (errors=1)

The problem is that _parse_author_name_and_email uses _split_contributor_names which splits the text using a set of separators when tey are found at any position of the text. Author names can contains ',' and email can contain +.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.