[Webkit-unassigned] [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84540





--- Comment #11 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2012-04-23 02:14:14 PST ---
(In reply to comment #10)
> (From update of attachment 138305 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138305&action=review
> 
> >>> Source/WebCore/bindings/scripts/CodeGenerator.pm:350
> >>> +    return 1 if $type eq "String";
> >> 
> >> AvoidInclusionOfType() is already used in CodeGenerator*.pm. I am a bit worrying that this would change the existing behaviors. No worry?
> > 
> > Umm I think the places where AvoidInclusionOfType is used to check whether to include header of type or not.
> > Looking at the current implementation of AvoidInclusionOfType it is avoiding inclusion only because it doesn't have headers like SVGPoint/SVGNumber adding above code won't change existing behaviour because it doesn't have headers for these type either.
> > IMO worry is if $arrayType is "SVGPoint/SVGNumber" it will skip headers.
> > 
> > So should I use IsPrimitiveType subroutine adding "String" to it or Write a new subroutine?
> 
> Thanks for the clarification. Currently there are no use cases for an SVGPoint/SVGNumber array. Let's keep it as-is.
> 
> BTW, shall we rename AvoidInclusionOfType() to SkipHeaderInclude() (or something clearer)?

Oke. I will repost patch with SkipIncludeHeader.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.