[Webkit-unassigned] [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84540





--- Comment #6 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2012-04-23 00:29:24 PST ---
(In reply to comment #5)
> (From update of attachment 138297 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138297&action=review
> 
> The approach looks good.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3028
> > +        if ($arrayType ne "String" && $arrayType ne "unsigned long") {
> 
> We do not want to add '$arrayType ne ...' in both CodeGeneratorJS.pm and CodeGeneratorV8.pm every time we support sequence<some_primitive_type>. Shall we make it a common subroutine in CodeGenerator.pm?
> 
> sub IsPrimitiveType
> {
>     my $type = shift;
>     return 1 if $type eq "String";
>     return 1 if $type eq "unsigned long";
>     ...;
>     return 0;
> }

Ohh I see we already have CodeGenerator::IsPrimitiveType we should be able to use that adding 
return 1 if $type eq "String";

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.