[Webkit-unassigned] [Bug 64883] Zoom only scales frames' content, not the frames themselves.

Sun Apr 22 22:30:46 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=64883

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #111398|review?                     |review-
               Flag|                            |

--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-22 22:30:46 PST ---
(From update of attachment 111398)
View in context: https://bugs.webkit.org/attachment.cgi?id=111398&action=review

> Source/WebCore/ChangeLog:7
> +

Please explain why you're making this change. r- because of the lack of explanation.

> Source/WebCore/rendering/RenderFrameSet.cpp:218
> -            gridLayout[i] = max(grid[i].value(), 0);
> +            gridLayout[i] = max(static_cast<int>(grid[i].value() * style()->effectiveZoom()), 0);

Are you sure we just want to cast it to int? Don't we need to use on of those fancy snapping functions listed on http://trac.webkit.org/wiki/LayoutUnit?

> LayoutTests/ChangeLog:10
> +        * fast/frames/frame-set-zoom-page-expected.png: Added.
> +        * fast/frames/frame-set-zoom-page-expected.txt: Added.
> +        * fast/frames/frame-set-zoom-page.html: Added.

There is no way to test this using a ref test?

> LayoutTests/fast/frames/frame-set-zoom-page.html:1
> +<html>

Missing DOCTYPE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.