[Webkit-unassigned] [Bug 84425] [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84425





--- Comment #3 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-22 19:47:50 PST ---
(From update of attachment 138044)
View in context: https://bugs.webkit.org/attachment.cgi?id=138044&action=review

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:114
> +    if (!coreNode || !coreNode->renderer())

Are you sure you need the second check here? None of the methods below seem to use it.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:117
> +    WebCore::HTMLInputElement* inputElement = static_cast< WebCore::HTMLInputElement*>(coreNode);

Style nit: extra space after the opening '<'.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:472
> +    return DumpRenderTreeSupportEfl::elementDoesAutoCompleteForElementWithId(mainFrame, id->ustring().utf8().data());

I think it makes sense to construct a String here and pass it as the second parameter to the DRTSupportEfl method:
  const String elementId(id->ustring().impl());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.