[Webkit-unassigned] [Bug 84544] New: [TestResultsServer] Impossible to inspect builds on non-Chromium builders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84544

           Summary: [TestResultsServer] Impossible to inspect builds on
                    non-Chromium builders
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zandobersek at gmail.com


In the timeline view on the http://test-results.appspot.com/ it is impossible to see details for any build when inspecting the layout tests results for non-Chromium builders.

TypeError occurs in dashboard_base.js when clicking on the dashboard with intent to inspect any build.
Stack trace obtained from the Web Inspector:

revisionLink (dashboard_base.js:954)
chromiumRevisionLink (dashboard_base.js:977)
updateBuildInspector (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):300)
selectBuild (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):248)
Dygraph.clickCallback (/dashboards/timeline_explorer.html#group=%40ToT%20-%20webkit.org&builder=Chromium%20Linux%20Release%20(Tests):224)
Dygraph.addEvent.o.dateWindow_ (dygraph-combined.js:1)
d (dygraph-combined.js:1)

It seems that in updateBuildInspector, Chromium revision link is being added despite not inspecting builds on a Chromium builder. shouldShowWebKitRevisionsOnly() returns false, and on further inspection it shows that isTipOfTreeWebKitBuilder() returns and undefined value which then gets converted to boolean value. Seems that isToTWebKit parameter of the BuilderGroup object is not properly assigned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.