[Webkit-unassigned] [Bug 84540] New: JS binding code generator doesn't handle "attribute unsigned long[]" well

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84540

           Summary: JS binding code generator doesn't handle "attribute
                    unsigned long[]" well
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: rgf748 at motorola.com, haraken at chromium.org
        Depends on: 82319


I made the following change but JSInternals.cpp doesn't compile. It tries to include sequence.h and JSsequence.h. It also generates:

JSValue jsInternals(ExecState* exec, JSValue slotBase, const Identifier&)
{
    JSInternals* castedThis = jsCast<JSInternals*>(asObject(slotBase));
    UNUSED_PARAM(exec);
    Internals* impl = static_cast<Internals*>(castedThis->impl());
    JSValue result = toJS(exec, castedThis->globalObject(), WTF::getPtr(impl->()));
    return result;
}

Index: Source/WebCore/testing/Internals.idl
===================================================================
--- Source/WebCore/testing/Internals.idl    (revision 114214)
+++ Source/WebCore/testing/Internals.idl    (working copy)
@@ -139,6 +139,8 @@

         [Conditional=INSPECTOR] unsigned long numberOfLiveNodes();
         [Conditional=INSPECTOR] unsigned long numberOfLiveDocuments();
+
+        readonly attribute sequence<unsigned long> fastMallocStatistics;
     };
 }

Index: Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
===================================================================
--- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm    (revision 114214)
+++ Source/WebCore/bindings/scripts/CodeGeneratorJS.pm    (working copy)
@@ -3025,7 +3025,7 @@
         AddToImplIncludes("SerializedScriptValue.h", $conditional);
         return "$value ? $value->deserialize(exec, castedThis->globalObject(), 0) : jsNull()";
     } elsif ($type eq "unsigned long[]") {
-        AddToImplIncludes("<wrt/Vector.h>", $conditional);
+        AddToImplIncludes("<wtf/Vector.h>", $conditional);
     } else {
         # Default, include header with same name.
         AddToImplIncludes("JS$type.h", $conditional);
Index: Source/WebCore/bindings/scripts/CodeGenerator.pm
===================================================================
--- Source/WebCore/bindings/scripts/CodeGenerator.pm    (revision 114214)
+++ Source/WebCore/bindings/scripts/CodeGenerator.pm    (working copy)
@@ -450,7 +450,7 @@
     my $object = shift;
     my $type = shift;

-    return $1 if $type =~ /^sequence<([\w\d_]+)>.*/;
+    return $1 if $type =~ /^sequence<([\w\d_\s]+)>.*/;
     return "";
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.