[Webkit-unassigned] [Bug 84340] [EFL] tabsToLinks ewk_view setting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84340





--- Comment #5 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-21 14:57:16 PST ---
(From update of attachment 138237)
View in context: https://bugs.webkit.org/attachment.cgi?id=138237&action=review

The change looks OK, but the function names still rub me in the wrong way. Both Qt and GTK+ seem to use "links included in focus chain" to describe this feature; perhaps ewk_view_setting_include_links_in_focus_chain_{get,set} makes more sense?

> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:309
> +    return ewk_view_setting_enable_tabs_to_links_get(m_view) ? KeyboardAccessTabsToLinks: KeyboardAccessDefault;

Minor nit: please add a space character before the ':'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.