[Webkit-unassigned] [Bug 84435] [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84435





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-04-21 00:58:31 PST ---
(From update of attachment 138071)
View in context: https://bugs.webkit.org/attachment.cgi?id=138071&action=review

Almost looks good to me except for trivial comments.

> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:602
> +    /* report received favicon only for main frame. */

Though this is trivial nits, it looks WebKit coding style tends to use '//' instead of '/*..*/' basically.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:110
> +    evas_object_smart_callback_add(mainFrame, "icon,changed", onFrameIconChanged, 0);

Though I'm not sure this is correct in this case, is it better to register this callback by alphabetical order ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.