[Webkit-unassigned] [Bug 84423] GtkWidgetBackingStoreX11.cpp should only be built if X11 is used

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 11:25:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84423





--- Comment #3 from Jeremy Huddleston <jeremyhu at apple.com>  2012-04-20 11:25:15 PST ---
Source/WebCore/plugins/gtk/PluginViewGtk.cpp also depends on X11, so the following is necessary to build (although the correct fix probably involves editing PluginViewGtk.cpp rather than avoiding it)

--- Source/WebCore/GNUmakefile.list.am.orig    2011-10-15 01:27:23.000000000 -0400
+++ Source/WebCore/GNUmakefile.list.am    2012-04-20 13:58:55.000000000 -0400
@@ -3986,7 +3986,6 @@
     Source/WebCore/platform/gtk/GtkUtilities.cpp \
     Source/WebCore/platform/gtk/GtkUtilities.h \
     Source/WebCore/platform/gtk/GtkWidgetBackingStoreCairo.cpp \
-    Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp \
     Source/WebCore/platform/gtk/GeolocationServiceGtk.cpp \
     Source/WebCore/platform/gtk/GeolocationServiceGtk.h \
     Source/WebCore/platform/gtk/GOwnPtrGtk.cpp \
@@ -4031,11 +4030,12 @@
     Source/WebCore/platform/gtk/WidgetGtk.cpp \
     Source/WebCore/platform/gtk/WidgetRenderingContext.cpp \
     Source/WebCore/platform/gtk/WidgetRenderingContext.h \
-    Source/WebCore/plugins/gtk/PluginPackageGtk.cpp \
-    Source/WebCore/plugins/gtk/PluginViewGtk.cpp
+    Source/WebCore/plugins/gtk/PluginPackageGtk.cpp

 if TARGET_X11
 webcoregtk_sources += \
+    Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp \
+    Source/WebCore/plugins/gtk/PluginViewGtk.cpp \
     Source/WebCore/plugins/gtk/gtk2xtbin.c \
     Source/WebCore/plugins/gtk/gtk2xtbin.h \
     Source/WebCore/plugins/gtk/xembed.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list