[Webkit-unassigned] [Bug 84414] Expose a flag so that fullscreen video on android can work with FULLSCREEN_API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84414





--- Comment #5 from Eric Carlson <eric.carlson at apple.com>  2012-04-20 10:46:38 PST ---
(From update of attachment 138034)
View in context: https://bugs.webkit.org/attachment.cgi?id=138034&action=review

The WebCore part of this looks fine to me modulo the simplification comment.

> Source/WebCore/platform/graphics/MediaPlayer.cpp:768
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
>  void MediaPlayer::enterFullscreen()
>  {
>      m_private->enterFullscreen();
> -}    
> +}
> +#elif ENABLE(NATIVE_FULLSCREEN_VIDEO)
> +bool MediaPlayer::enterFullscreen() const
> +{
> +    return m_private->enterFullscreen();
> +}

I think you might as well just change m_private->enterFullscreen to return a bool so you can combine these.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.