[Webkit-unassigned] [Bug 84457] [Qt] Make it possible to use v8 WebKit2 core

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 09:15:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84457





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-04-20 09:15:32 PST ---
Attachment 138104 did not pass style-queue:

Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:73:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:79:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:87:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:96:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:108:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSStringRef.h:122:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:343:  Extra space between int and version  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:344:  Extra space between JSClassAttributes and attributes  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:347:  Extra space between JSClassRef and parentClass  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:352:  Extra space between JSObjectInitializeCallback and initialize  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:353:  Extra space between JSObjectFinalizeCallback and finalize  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:354:  Extra space between JSObjectHasPropertyCallback and hasProperty  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:355:  Extra space between JSObjectGetPropertyCallback and getProperty  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:356:  Extra space between JSObjectSetPropertyCallback and setProperty  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:357:  Extra space between JSObjectDeletePropertyCallback and deleteProperty  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:358:  Extra space between JSObjectGetPropertyNamesCallback and getPropertyNames  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:359:  Extra space between JSObjectCallAsFunctionCallback and callAsFunction  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:360:  Extra space between JSObjectCallAsConstructorCallback and callAsConstructor  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:361:  Extra space between JSObjectHasInstanceCallback and hasInstance  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:362:  Extra space between JSObjectConvertToTypeCallback and convertToType  [whitespace/declaration] [3]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:381:  The parameter name "definition" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:389:  The parameter name "jsClass" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:396:  The parameter name "jsClass" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:409:  The parameter name "jsClass" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:419:  The parameter name "callAsFunction" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:430:  The parameter name "jsClass" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:430:  The parameter name "callAsConstructor" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:501:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:510:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:510:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:519:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:530:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:542:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:542:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:542:  The parameter name "attributes" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:553:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:565:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:577:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:577:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:585:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:595:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:604:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:617:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:626:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:638:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:647:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:655:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:662:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:670:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:679:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSObjectRef.h:687:  The parameter name "accumulator" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:51:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:65:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:74:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:83:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:92:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:101:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:110:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:119:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:129:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:129:  The parameter name "jsClass" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:142:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:152:  The parameter name "a" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:163:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:209:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:220:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:231:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:242:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:252:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:262:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:272:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:284:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSValueRef.h:294:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/V8JSCAPIShims/JSContextRef.h:41:  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSContextRef.h:42:  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/JSContextRef.h:44:Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/JavaScriptCore.pri',..." exit_code: 1
  The parameter name "group" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/V8JSCAPIShims/APICast.h:4:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:64:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/V8JSCAPIShims/JavaScript.h:6:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 81 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list