[Webkit-unassigned] [Bug 83282] Web Inspector: Allow inspection of Web Socket Frames

Fri Apr 20 08:36:58 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=83282

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138080|review?                     |review-
               Flag|                            |

--- Comment #36 from Pavel Feldman <pfeldman at chromium.org>  2012-04-20 08:36:53 PST ---
(From update of attachment 138080)
View in context: https://bugs.webkit.org/attachment.cgi?id=138080&action=review

One nit and I think it is ready.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:932
> +    InspectorInstrumentation::didSendWebSocketFrame(m_document, m_identifier, frame);

The m_deflateFramer.deflate call above will mutate frame's data and, as a result, you will get garbled data instrumented. You could move this instrument call back to before deflate and assume that deflate is always successful. When we get a bug report claiming otherwise, we'll start instrumenting raw data*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.