[Webkit-unassigned] [Bug 84235] Web Inspector: Does not have search navigation button for going through matches in either direction (prev, next)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84235





--- Comment #22 from sam <dsam2912 at gmail.com>  2012-04-20 07:01:40 PST ---
Thank you Pavel for review.
I have uploaded the patch with review comments incorporated.

(In reply to comment #20)
> (From update of attachment 138043 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138043&action=review
> 
> This is almost ready, few nits left.
> 
> > Source/WebCore/inspector/front-end/SearchController.js:344
> > +             case "prev":
> 
have corrected it.

> As I mentioned, case should be below switch, no indentation.
> 
> > Source/WebCore/inspector/front-end/inspector.css:279
> > +    -webkit-border-image: none;
> 
corrected
> Remove this.
> 
> > Source/WebCore/inspector/front-end/inspector.css:280
> > +    border: 1px solid rgba(120, 120, 120, 0.4);
> 
> On my box, it looks like there is a gray border by default that vanishes on hover. I'd suggest to make this one transparent and move the definition into the :hover.
> 
changed

> > Source/WebCore/inspector/front-end/inspector.css:290
> > +    -webkit-border-image: none;
> 
> Remove this.
> 
corrected

> > Source/WebCore/inspector/front-end/inspector.css:302
> > +    background-image: url('Images/searchPrev.png');
> 
> We do not quote paths in url()
> 
changed
> > Source/WebCore/inspector/front-end/inspector.css:306
> > +    background-image: url('Images/searchNext.png');
> 
> ditto

changed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.