[Webkit-unassigned] [Bug 82860] [EFL] Add setting API for author and user styles.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82860





--- Comment #17 from Kamil Blank <k.blank at samsung.com>  2012-04-19 22:48:52 PST ---
Thank you for review!

(In reply to comment #15)
> (From update of attachment 135834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135834&action=review
> 
> > Source/WebKit/efl/ChangeLog:9
> > +        Add missing implementation setAuthorAndUserStylesEnabled to EFL's
> > +        DumpRenderTreeSupport.
> > +
> > +        Reviewed by NOBODY (OOPS!).
> 
> Nit: The format of this change log entry is inconsistent with the format used in the other change log entries in this patch. To be consistent, the "Reviewed by" line should come after the bug URL.

Thanks. I'll fix it!

(In reply to comment #16)
> (From update of attachment 135834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135834&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:353
> > +void LayoutTestController::setAuthorAndUserStylesEnabled(bool flag)
> 
> Nit: You may want to consider substituting "enable" for "flag" for the parameter name so as to be consistent with the name of this parameter in DumpRenderTreeSupportEfl::setAuthorAndUserStylesEnabled().

I'll leave it as it is as almost all functions inside Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp use name "flag".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.