[Webkit-unassigned] [Bug 71771] Inserting empty html moves caret

Thu Apr 19 22:46:24 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=71771

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137853|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2012-04-19 22:46:24 PST ---
(From update of attachment 137853)
View in context: https://bugs.webkit.org/attachment.cgi?id=137853&action=review

> LayoutTests/editing/inserting/insert-empty-html.html:6
> +<head>
> +<script src="../../fast/js/resources/js-test-pre.js"></script>
> +</head>
> +

You don't need to have a head for this. You can just move js-test-pre.js to body.

> LayoutTests/editing/inserting/insert-empty-html.html:19
> +    var sel = window.getSelection();

Please don't use abbreviations like sel.

> LayoutTests/editing/inserting/insert-empty-html.html:23
> +    // Set the caret position

This comment repeats the code. Please remove.

> LayoutTests/editing/inserting/insert-empty-html.html:26
> +    // Insert the empty html

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.