[Webkit-unassigned] [Bug 76152] Incorrect handling of CSS escape sequences that encode surrogates

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:53:07 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=76152


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131605|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #14 from Kent Tamura <tkent at chromium.org>  2012-04-19 16:53:06 PST ---
(From update of attachment 131605)
View in context: https://bugs.webkit.org/attachment.cgi?id=131605&action=review

> Source/WebCore/css/CSSParser.cpp:7759
> +            // Lead/High surrogate character

This comment looks useless.

> Source/WebCore/css/CSSParser.cpp:7761
> +            *result = U16_LEAD(unicode);
> +            ++result;

We can write this as: *result++ = U16_LEAD(unicode);

> Source/WebCore/css/CSSParser.cpp:7762
> +            // Trail/Low surrogate character

This comment looks useless.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list