[Webkit-unassigned] [Bug 63807] fast/loader/create-frame-in-DOMContentLoaded.html asserting in FrameLoader::loadWithDocumentLoader on Windows since it was added

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 19 16:02:53 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=63807


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131588|review?                     |review-
               Flag|                            |




--- Comment #9 from Nate Chapin <japhet at chromium.org>  2012-04-19 16:02:52 PST ---
(From update of attachment 131588)
View in context: https://bugs.webkit.org/attachment.cgi?id=131588&action=review

This change seems strange to me, but the link to the build output is dead, so I'm short on context. Regardless, I'm pretty sure that this isn't the right place to exit for this particular case.

> Source/WebCore/loader/FrameLoader.cpp:715
> +    if (m_stateMachine.creatingInitialEmptyDocument())
> +        return;

It looks like this patch is causeing test failures (based on the cr-linux bot output). This seems like an overly broad place to do this check anyway. I would suggest trying it in Document::implicitClose().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list