[Webkit-unassigned] [Bug 9767] WebPreference methods setAllowsAnimatedImages: and setAllowsAnimatedImageLooping: don't actually affect WebView behaviors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9767


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130705|review?                     |review-
               Flag|                            |




--- Comment #35 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-04-19 14:48:01 PST ---
(From update of attachment 130705)
View in context: https://bugs.webkit.org/attachment.cgi?id=130705&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/images/disallow-animated-images.html

This needs to have some explanation of what the change is doing.

> Source/WebCore/platform/graphics/BitmapImage.cpp:454
> -    if (!skippingFrames && imageObserver()->shouldPauseAnimation(this))
> +    if (imageObserver()->shouldPauseAnimation(this))

Why was !skippingFrames removed?

> Source/WebCore/rendering/RenderObject.cpp:2593
> +    return !document()->inPageCache() && !document()->view()->isOffscreen() && (!settings || settings->allowAnimatedImages());

Does this also affect static images, not just animating ones?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.