[Webkit-unassigned] [Bug 29993] Zooming while a CSS animation is running does not recompute endpoints

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29993


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115469|review?                     |review-
               Flag|                            |




--- Comment #22 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-04-19 14:43:33 PST ---
(From update of attachment 115469)
View in context: https://bugs.webkit.org/attachment.cgi?id=115469&action=review

> Source/WebCore/page/animation/CompositeAnimation.cpp:209
> +            int numAnims = targetStyle->animations()->size();

Shouldn't this be a size_t?

> Source/WebCore/page/animation/CompositeAnimation.cpp:212
> +                AtomicString animationName(anim->name());

Why make the AtomicString if you're going to continue two lines below?

> Source/WebCore/page/animation/CompositeAnimation.cpp:217
> +                RefPtr<KeyframeAnimation> keyframeAnim = m_keyframeAnimations.get(animationName.impl());

Does this actually need an AtomicString?

> Source/WebCore/page/animation/CompositeAnimation.cpp:219
> +                m_keyframeAnimations.set(animationName.impl(), keyframeAnim);

Why does it need to be put back in the hash map?

> Source/WebCore/page/animation/KeyframeAnimation.h:57
> +    void updateKeyframes(RenderObject* renderer, RenderStyle* unanimatedStyle);

'renderer' can be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.