[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #20 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-04-19 13:25:58 PST ---
(In reply to comment #16)
> (From update of attachment 137946 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=137946&action=review
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:652
> > +static bool toBool(JSStringRef value)
> 
> Could be inline.
Fixed.
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:655
> > +    const JSC::UString& uVal = value->ustring();
> > +    return (uVal == "true" || uVal == "1");
>
Doesn't it bring 1 more conversion for "val" to UString?
Fixed.

> You can simplify this snippet by using the equals() overloads defined in JSStringUtils.cpp:
>   return equals(value, "true") || equals(value, "1");
> 
> > Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:658
> > +static int toInt(JSStringRef value)
> 
> Why not atoi(3)?
I had impression (probably wrong) that Eina_Value is an "official" mean for converting one type to another in EFL.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.