[Webkit-unassigned] [Bug 83007] [EFL] EFL's LayoutTestController overridePreference implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83007





--- Comment #16 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-04-19 12:40:17 PST ---
(From update of attachment 137946)
View in context: https://bugs.webkit.org/attachment.cgi?id=137946&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:652
> +static bool toBool(JSStringRef value)

Could be inline.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:655
> +    const JSC::UString& uVal = value->ustring();
> +    return (uVal == "true" || uVal == "1");

You can simplify this snippet by using the equals() overloads defined in JSStringUtils.cpp:
  return equals(value, "true") || equals(value, "1");

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:658
> +static int toInt(JSStringRef value)

Why not atoi(3)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.