[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048





--- Comment #13 from Takashi Sakamoto <tasak at google.com>  2012-04-19 12:37:43 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (From update of attachment 137623 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=137623&action=review
> > 
> > > Source/WebCore/ChangeLog:7
> > > +        http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
> > 
> > Could you explain the change itself briefly?

I see. Done.

> > 
> > > Source/WebCore/css/CSSStyleSelector.cpp:1638
> > > +void CSSStyleSelector::applyResetStyleInheritance(MatchResult& result)
> > 
> > This isn't the right approach.
> > - The flag should affect not only for direct children of the shadow boundary
> > - Allocating properties for each style resolution is too expensive.
> > 
> > I think this "reset" thing should be handled at where we compute the inheritance in RenderStyle object
> > because RenderStyle is responsible for style inheritance in WebKit.
> > You can find such places by seeing the callers of RenderStyle::inheritFrom().

I'm sorry. I misunderstood the spec. I agree that the approach (seeing the callers of RenderStyle::inheritFrom) is right. I think, CSSStyleSelector::styleForElement() is the place.

I re-created a patch and also added new test cases for changing resetStyleInheritance dynamically.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.