[Webkit-unassigned] [Bug 84325] [GTK] Build and run TestWebKitAPI unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84325


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #137866|review?                     |review-
               Flag|                            |




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2012-04-19 06:21:34 PST ---
(From update of attachment 137866)
View in context: https://bugs.webkit.org/attachment.cgi?id=137866&action=review

> Source/ThirdParty/gtest/GNUmakefile.am:65
> +# #included by gtest-all.cc.

Did you mean to have the second '#' here?

> Tools/Scripts/run-gtk-tests:47
> +    TEST_DIRS = [ "unittests", "WebKit2APITests", "TestWebKitAPI/WTF" ]

I'm pretty sure

> Tools/Scripts/run-gtk-tests:271
> +    def _run_test_google(self, test):
> +        tester_command = [test]
> +        skipped_tests_cases = self._test_cases_to_skip(test)
> +        if skipped_tests_cases:
> +            tester_command.append("--gtest_filter=-%s" % ":".join(skipped_tests_cases))
> +
> +        return not self._create_process(tester_command, env=self._test_env).wait()
> +
> +    def _run_test(self, test):
> +        if "unittests" in test or "WebKit2APITests" in test:
> +            return self._run_test_glib(test)
> +
> +        if "TestWebKitAPI" in test:
> +            return self._run_test_google(test)
> +
> +        return False
> +

The logic for running the API tests is already in Tools/Scripts/run-api-tests, so we get that script working instead probably.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.